Both Aud and Willow had souls when they did the acts that called down D'hoffryn to offer them the job. I don't actually see any reason they'd stop having them. The fact that Anya was seriously bothered by her actions in the frathouse suggests that she can feel guilt. This seems to be something people with souls experience.
Of all the demons, only vampires are shown to be dead and deemed 'soulless' in the buffyverse. While many demons are considered evil (want to harm/control humans), we don't hear them spoken of as specifically being soulless. Just dangerous and willing to hurt humans to get whatever their agenda is accomplished. Since humans are often also willing to hurt humans to get their agenda accomplished,
I am not convinced that lack of a soul is a prerequisite for being deemed 'demon'.
Evil is evil. Some evil is human. Some evil is demon. Animal violence is rarely considered 'evil' even when lethal because animals aren't considered capable of deciding between right and wrong.
Being evil requires some MORAL AGENCY - it is a choice. It does not require the absence of a soul, though the absence of a soul makes it much easier to choose to do 'evil' as one has no capacity to feel guilt if one has no soul (at least that's the case in the buffyverse).
Humans usually know right from wrong and mostly (we are told) try to do 'right'. Evil humans choose to do wrong. Some are considered sociopathic/psychopathic -- and deemed to lack human empathy. They know that things are wrong. They simply don't or can't care.
Demons don't always seem to have a moral compass but only vampires are outright stated to be amoral (incapable of discerning/or simply don't care about) right or wrong. It seems that vampires are the sociopaths of the demon worlds.
Although vengeance demons do things most humans consider evil, they actually do seem to be motivated by some sort of
trickster justice. Their "morality" isn't so much absent as skewed (at least by most human standards). They respond when humans are in pain. They mete out 'justice' or 'vengeance' based on the wish of humans. Most of those humans aren't fully cognizant of the potential endpoint of those wishes, but some (probably most) of those wishes aren't pleasant.
Do all sentient creatures have souls? That's a big question. I have no idea.
Since we (writers and creators of fictional universes) are making up mythology -- as far as I know, demons and vampires are not real -- I guess it depends on the writers of the universe in particular. Oddly, i cannot recall many supernatural books that stated that 'no soul was present' in demon x or y.
Demons seem to be on a sliding scale of 'bad' to 'world ending evil'. Some demons aren't even considered 'evil' they are just supernatural beings, mostly with some kind of power that is "more than" human/animal. Most of us in the western world don't like the idea of cats as food, but other than that, there's no evidence that Clem did anything 'evil'. Many animals including most humans, eat other animals. I often find it interesting which animals are considered prey (food) and which animals are considered family (pets) and which animals are considered somewhere in between (things like rabbits seem to straddle that line, occasionally pigs, some birds and other small mammals). In many countries horse meat is considered acceptable. People also keep horses as work animals or pets.
So... if what we eat doesn't make us evil. What constitutes evil? Is it simply that humans believe they're to be at the top of the food chain, and anything that wants to rule/kill them is 'evil'?
- Sentient beings that kill or hurt humans and have 'powers' are demons and usually considered evil?
- Sentient human appearing beings that kill or hurt humans and have no powers are 'evil humans'?
- Non-sentient beings that kill or hurt humans are 'dangerous predator' animals?
What is sentience exactly? Where do you draw the line regarding 'powers?
The buffyverse vampires are stated to have no souls unless otherwise advised. I'm not actually sure there's much about other vampires. Mostly, demons that hurt humans are considered 'evil' -- but there are a lot of different worlds out there and a lot of different variants on the theme. Since Buffy, more vampires appear to have soul/no soul as a thing... but before that, I don't really see a lot about it.
It seems that death is the reason for the loss of souls in vampires -- as anything that has died has been deemed to have lost its soul... does this mean humans who are resuscitated are soulless or is proper death (no electrical activity in brain or heart type death) required for soul to depart?
Since vampires are the only demon whose creation requires death, it makes sense that they alone would not have souls.
I'm not claiming to be an expert nor have i read all the extant theory or supernatural fiction.